Repository navigation
CI: fix conditional for PR merge command - #17541
Merged
Merged
Conversation
Co-authored-by: Matti Picus <[email protected]>
Member
|
something must be off: there is no circleCI build on this PR |
mattip
reviewed
Oct 12, 2020
Contributor
Author
|
It may be related to the fact that I had set up circleci to run on my own fork to test this (it worked fine with -v) - I will disable that then try close/reopen to see if that triggers the build |
Contributor
Author
|
Ok seems like that did the trick - I think it was the fact that I had circleCI configured for my own fork as well that was suppressing the run here. |
Member
Whoops. Feel free to revert |
rossbar
force-pushed
the
circleci_envvar_fix
branch
from
October 12, 2020 17:55
ea1b3f1 to
b6d9582
Compare
Member
Member
|
That worked. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Correct bash syntax for checking whether a PR is active in circleCI. Fixes #17524 .