Repository navigation
BUG: Fix overflow warning on apple silicon - #18571
Conversation
|
@isuruf, I know that did not work in gh-18555 which may actually just be the identical issue? Before we add more clang workaround, can you make sure to compiling with I am not on top of these efforts here, so ignore if this is obviously unhelpful... |
The exception is still there if I add that flag without this PR. |
|
The one PyPy failure seems unrelated: Let's see if there's more opinions on a preference of this PR vs. gh-17712. I'd be inclined to merge this one. |
|
I think this would be fine. I think my solution on #17712 would be a bit cleaner (and have the advantage of unifying the code path of single-value and vector computations), but I was stymied by the time taken to make it work with the 128-bit code path. This is certainly a simpler and more direct solution. |
Co-authored-by: Matti Picus <[email protected]>
Alternative to #17712