Skip to content

SIMD: Force inlining all functions that accept AVX registers - #19529

Merged
seberg merged 1 commit into
numpy:mainfrom
DWesl:simd-function-re-inline
Jul 20, 2021
Merged

seberg merged 1 commit into
numpy:mainfrom
DWesl:simd-function-re-inline

Conversation

@DWesl

@DWesl DWesl commented Jul 20, 2021 •

Copy link
Copy Markdown
Contributor

To avoid spilling vector registers into the stack, which may
reduce the performance and also to workaround GCC bug on WIN64.


I thought I had grabbed this from main, but now I can't find it, so it might have originally been a commit on #18330.

Edit: it looks like 0559808 is the original

  To avoid spilling vector registers into the stack, which may
  reduce the performance and also to workaround GCC bug on WIN64.
@charris
charris requested a review from seiko2plus July 20, 2021 17:00
@seberg

seberg commented Jul 20, 2021

Copy link
Copy Markdown
Member

Makes sense to me and since Sayed proposed the original thing, lets just get this in. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants