Skip to content

BLD: change file extension for installed static libraries back to .lib - #23983

Merged
mattip merged 1 commit into
numpy:mainfrom
rgommers:fix-windows-npyrandom
Jun 19, 2023
Merged

mattip merged 1 commit into
numpy:mainfrom
rgommers:fix-windows-npyrandom

Conversation

@rgommers

Copy link
Copy Markdown
Member

This fixes the test_cython failure mentioned in gh-23981.

@rgommers rgommers added 36 - Build Build related PR Meson Items related to the introduction of Meson as the new build system for NumPy component: numpy.random labels Jun 19, 2023
@rgommers

Copy link
Copy Markdown
Member Author

That worked, from a Windows wheel build log:

Linking static target numpy/random/npyrandom.lib

@mattip

mattip commented Jun 19, 2023

Copy link
Copy Markdown
Member

The two queued checks are not relevant for this PR, the others are passing.
Thanks @rgommers.

@mattip
mattip merged commit 7190108 into numpy:main Jun 19, 2023
@rgommers
rgommers deleted the fix-windows-npyrandom branch June 19, 2023 06:20
@rgommers rgommers added this to the 2.0.0 release milestone Jun 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

36 - Build Build related PR component: numpy.random Meson Items related to the introduction of Meson as the new build system for NumPy

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants