Repository navigation
BUG: Fix assumed length f2py regression - #24299
Merged
Merged
Conversation
HaoZeke
force-pushed
the
gh24008_regression_f2py
branch
from
August 5, 2023 19:53
ae81cf9 to
3b862dd
Compare
Member
Author
|
Travis build failure seems unrelated. |
Member
|
Which test run covers f2py + slow tests? |
Closes numpygh-24008. Essentially, array and length setup needs to be done before the length defaults kick in.
Since it belongs logically to the tests where character array shapes and types are determined
Member
Author
|
The ones with |
HaoZeke
force-pushed
the
gh24008_regression_f2py
branch
from
August 24, 2023 10:52
e46cf48 to
9a44f54
Compare
Member
Author
|
Should be good to go now, @mattip |
Member
|
Thanks @HaoZeke |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #24008. Many thanks to @Akahan12 for narrowing down the problematic commit.
@charris this will need a backport.