Repository navigation
MAINT: remove setup.py and other files for distutils builds - #24519
Merged
Merged
Conversation
rgommers
marked this pull request as draft
August 24, 2023 11:27
rgommers
force-pushed
the
remove-setuppy
branch
from
August 27, 2023 09:17
6be249a to
53636a3
Compare
Moving it to Meson is going to take a bit of time, and in the meantime we have to disable it, because it's the only job that still needs the `setup.py` based build and we'd like to remove support for building with `setup.py`.
rgommers
force-pushed
the
remove-setuppy
branch
from
September 13, 2023 20:53
53636a3 to
59b4955
Compare
Member
Author
|
One more CI job to deal with, the |
rgommers
marked this pull request as ready for review
September 15, 2023 20:22
Member
Author
|
This is now ready to merge. Of the two failures here, the debug job was an We discussed this change in the community meeting last Wednesday, and everyone there was in favor of removing the |
charris
approved these changes
Sep 15, 2023
Member
|
Thanks Ralf. |
3 of 7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not yet merge-able, but running all CI jobs to see what's left.