Skip to content

TYP: Explicitly declare dtype and generic as hashable - #24623

Merged
charris merged 1 commit into
numpy:mainfrom
BvB93:hash2
Sep 3, 2023
Merged

charris merged 1 commit into
numpy:mainfrom
BvB93:hash2

Conversation

@BvB93

@BvB93 BvB93 commented Sep 2, 2023

Copy link
Copy Markdown
Member

Closes #24621

Explicitly mark dtype and generic, the only two hashable classes whose stubs override __eq__, as hashable via the addition of a __hash__ method.

@BvB93 BvB93 added 09 - Backport-Candidate PRs tagged should be backported 41 - Static typing labels Sep 2, 2023
@BvB93 BvB93 changed the title TYP: Explicitly declare dtype and generic hashable TYP: Explicitly declare dtype and generic as hashable Sep 2, 2023
@charris
charris merged commit 14709cf into numpy:main Sep 3, 2023
@charris

charris commented Sep 3, 2023

Copy link
Copy Markdown
Member

Thanks Bas.

@BvB93
BvB93 deleted the hash2 branch September 3, 2023 16:16
@charris charris changed the title TYP: Explicitly declare dtype and generic as hashable TYP: Explicitly declare dtype and generic as hashable Sep 3, 2023
@charris charris removed the 09 - Backport-Candidate PRs tagged should be backported label Sep 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TYP: np.dtype is not Hashable

2 participants