Skip to content

DOC: Add legacy directive to mark outdated objects - #24939

Merged
HaoZeke merged 2 commits into
numpy:mainfrom
melissawm:legacy-directive
Nov 17, 2023
Merged

HaoZeke merged 2 commits into
numpy:mainfrom
melissawm:legacy-directive

Conversation

@melissawm

@melissawm melissawm commented Oct 16, 2023 •

Copy link
Copy Markdown
Member

This mirrors the current SciPy functionality, with styling compatible with the current version of the pydata-sphinx-theme (0.13.3) used to build the docs.

Part of #23999

EDIT: Rendered artifact of docs (showing functionality)

This mirrors the current SciPy functionality, with styling compatible with the current version of the pydata-sphinx-theme (0.13.3) used to build the docs.

[skip azp][skip cirrus]

@rossbar rossbar left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 for this! Not a blocker for this PR, but perhaps this is something that can be upstreamed/packaged as an extension since multiple projects are using it (and others may be interested).

Anyways - just food for thought; we can move that discussion to a more appropriate forum!

@melissawm

Copy link
Copy Markdown
Member Author

Yeah, if it's useful I'm happy to do it, should not be too hard!

@seberg seberg left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Somehow, I would have leaned towards making the function the default (or just some "this is considered legacy", and submodule/function as a word opt in to the leading sentence.

But LGTM, and I guess this is exactly what is in SciPy, so no point in bike-shedding. Should we just put in because a follow up will soon use it?

@melissawm

Copy link
Copy Markdown
Member Author

My proposal would be to take that in if you want to use it, and if I actually do the refactor I'll leave it more general. Just for now my concern would be to have something so similar in different projects with different defaults may be too confusing. I should be able to refactor this into a standalone soon but don't want to block usage if you folks need it :)

@rgommers rgommers added this to the 2.0.0 release milestone Oct 25, 2023
@mtsokol

mtsokol commented Nov 17, 2023

Copy link
Copy Markdown
Member

Hi! Do you mind merging this PR? I would like to use it for e.g. np.vdot function.

@HaoZeke
HaoZeke merged commit 605e345 into numpy:main Nov 17, 2023
@melissawm

Copy link
Copy Markdown
Member Author

Thanks all - I will follow up with the separation into a standalone package as soon as I can get to it 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants