Repository navigation
MAINT: Update Pyodide to 0.25.1 - #26185
Merged
Merged
Conversation
charris
added
03 - Maintenance
09 - Backport-Candidate
Member
Author
|
Patching pyodide.py is disabled here because it was failing. Not sure what has changed. |
Contributor
|
Hi, @charris! I was fixing this locally actually, now I see that you've done that already :) Thank you for the fix, maybe I should have commented there earlier, but didn't want to pester people on a weekend. It should now be okay to remove the patch step and the file because the commit that the patch was made out of has been included in the |
charris
force-pushed
the
update-pyodide-version
branch
from
March 31, 2024 18:30
81458b4 to
42bbfce
Compare
Member
Author
|
@agriyakhetarpal Thanks for the information. I've removed the patch file and the commented out lines. |
agriyakhetarpal
left a comment
agriyakhetarpal
left a comment
Contributor
There was a problem hiding this comment.
The build and tests are passing here, so LGTM. Thank you for the quick fix!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #26164.