Skip to content

DOC: Follow-up fixes for new theme - #26311

Merged
mattip merged 1 commit into
numpy:mainfrom
melissawm:fix-new-theme
Apr 18, 2024
Merged

mattip merged 1 commit into
numpy:mainfrom
melissawm:fix-new-theme

Conversation

@melissawm

Copy link
Copy Markdown
Member

Fixes spacing between logo and navbar section titles, and admonition colors.

This is a follow-up to #26125 - I noticed the navbar spacing was off, and that the regular admonitions were erroneously taking colors from the legacy admonition colors.

Fixes spacing between logo and navbar section titles, and admonition colors.

[skip azp] [skip cirrus]
@mattip

mattip commented Apr 18, 2024

Copy link
Copy Markdown
Member

Thanks. If you add this to the commit, only doc building (circleci) will run:

[skip azp][skip actions][skip cirrus]

I wonder how we can make that the default for PRs that only touch ./doc

@mattip

mattip commented Apr 18, 2024

Copy link
Copy Markdown
Member

Looks better: compare this PR to the same page in devdocs. The heading fits into one line and the "Examples" admonitions are style in a blue rather than an orange.

@mattip
mattip merged commit 1e9af74 into numpy:main Apr 18, 2024
@mattip

mattip commented Apr 18, 2024

Copy link
Copy Markdown
Member

Thanks @melissawm

@melissawm

Copy link
Copy Markdown
Member Author

Thanks. If you add this to the commit, only doc building (circleci) will run:

[skip azp][skip actions][skip cirrus]

I wonder how we can make that the default for PRs that only touch ./doc

Don't know about a default, but I'd be happy to submit a PR for a [docs only] option like we have in scipy: https://github.com/scipy/scipy/blob/main/.github/workflows/commit_message.yml

@mattip

mattip commented Apr 18, 2024

Copy link
Copy Markdown
Member

A [docs only] option makes sense to me.

@charris charris removed the 09 - Backport-Candidate PRs tagged should be backported label Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants