Repository navigation
DOC: Add datetime64 example for 'Now' to get the current time - #26477
Shreyjaradi wants to merge 3 commits into
Conversation
|
This fails doctests. You should add a |
|
@mattip Thank you so much, I have made the changes, this is my first open source contribution at PyCon US 2024 Pittsburgh. |
|
@mattip , Can we close this ? |
|
Just FYI, it's always a good idea to submit features on a branch other than your I will go ahead and close as requested! |
|
Thank you so much. I will keep this in mind for the future. Thank you so
much.
…On Tue, 21 May 2024 at 00:23, Ross Barnowski ***@***.***> wrote:
Just FYI, it's always a good idea to submit features on a branch other
than your main branch - one reason why is that maintainers often push
minor suggestions to the PR to make things quicker; however this is not
possible for PRs that originate from the main branch on your fork. Just a
little nugget for next time!
I will go ahead and close as requested!
—
Reply to this email directly, view it on GitHub
<#26477 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AGD2T2CS33R22W3A6LW3ENLZDLK3JAVCNFSM6AAAAABH5VPZ3KVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMRRG43DIMBXGU>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
@rossbar I think maybe @Shreyjaradi meant "Can we merge this?" ? Issue #10003 is still open and the "now" and "today" strings remain undocumented. |
No description provided.