Repository navigation
MAINT: mark scipy-openblas nightly tests as allowed to fail - #26991
Merged
Merged
Conversation
ngoldbaum
force-pushed
the
scipy-openblas-fix-ci
branch
from
July 19, 2024 21:46
c1e3532 to
5cf3455
Compare
Member
|
Thanks, I guess we have to do this, it's too easy to miss other failures if things are always red. I really wish this would just make things orange. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Once #26989 is merged, my understanding is that this will make our CI green once again.
I could also individually xfail the tests that are failing if we'd prefer that. I'm just not sure how to detect the nightly openblas wheel at runtime in the test to only xfail it in that case.
xref #26824 (comment)