Repository navigation
Conversation
Add keyword `nrows` to specify the number of rows to read. 1. We should not use keywords `nrows` and `skip_footer` in the same time. 2. If there's not enough lines (less than nrows) to read, an exception would raise.
Member
There was a problem hiding this comment.
You should add new arguments to the end of the function signature, so that you don't break code using positional arguments.
Member
|
You should also add some tests for the new behavior, to numpy/lib/tests/test_io.py |
Contributor
Author
|
Thank you, your comments are to the points. And sorry for my lack of experience and carelessness. |
Member
|
No problem, @styra, your efforts are appreciated and very welcome: don't let these mistakes scare you away from fixing this PR and/or sending more in the future! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add keyword
nrowsto specify the number of rows to read.nrowsandskip_footerin the same time.