Repository navigation
Conversation
There was a problem hiding this comment.
I am curious how you thought to use .base here, rather than the dtype directly. I can imagine why it might be a good idea, just wondering if you had explicit rationale for it.
There was a problem hiding this comment.
It is because of subarrays, and I should probably add a comment explaining that. The idea is to drop the subarray part and get just the type, because that is what the old code did:
The old code did currentdescr = descr[1], and remember that descr has the form (name, type, shape), so that would drop the shape. In the same way doing .base drops the shape.
There was a problem hiding this comment.
Acutally, using .subdtype will be clearer, I'll do that instead.
|
Looks good. |
fa48468 to
78b8209
Compare
There was a problem hiding this comment.
In Tweety Bird voice, "It is, it is too long".
|
Using |
|
Might also add docstrings to the functions. |
Structured dtypes with padding bytes fail in MaskedArrays because of padding bytes in `dtype.descr`. Fix is to avoid using dtype.descr.
|
Thanks @charris, updated. |
|
Nitpick: Sentences begin with a capital and end with a period. |
|
Fixed up the capitalization in #7894, so closing this. Thanks Allan. |
3 participants
Structured dtypes with padding bytes fail in MaskedArrays because of padding bytes in
dtype.descr. Fix is to avoid using dtype.descr.This is a followup/alternate implementation of #7788.