This repository was archived by the owner on Apr 21, 2022. It is now read-only.
Repository navigation
fix: run oclif-dev pack:deb as non root user - #122
Closed
microwavesafe wants to merge 1 commit into
Closed
microwavesafe wants to merge 1 commit into
microwavesafe wants to merge 1 commit into
Conversation
The only part of the pack:deb command that requires root are the chown and chgrp shell commands. I don't run oclif-dev as root, so the command fails at this point. By adding sudo, it asks for the password and only runs these commands with root privileges, which seems sensible to me. The change will have no effect if already running with root privileges.
|
Thanks for the contribution! Before we can merge this, we need @microwavesafe to sign the Salesforce.com Contributor License Agreement. |
|
Any updates on this? We many headaches with this and had to patch-package with these changes |
Contributor
|
Can you move this to a non-master branch? (tl;dr - we have to run a script to test 3rd party commits with secrets and they can't be on master) |
Author
|
I'm not really sure what you want me to do. To be honest, this is such a small change you could implement outside this pull request and I'll just close this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The only part of the pack:deb command that requires root are the chown and chgrp shell commands. I don't run oclif-dev as root, so the command fails at this point. By adding sudo, it asks for the password and only runs these commands with root privileges, which seems sensible to me.
The change will have no effect if already running with root privileges.