Skip to content

Add support for extraHeaders on Invitation.accept - #910

Merged
james-criscuolo merged 1 commit into
onsip:masterfrom
danvirsen:master
Feb 22, 2021
Merged

james-criscuolo merged 1 commit into
onsip:masterfrom
danvirsen:master

Conversation

@danvirsen

Copy link
Copy Markdown
Contributor

Added extraHeaders to the Invitation.accept method to fix issue #909.

I'm not familiar with the repository, but I think the implementation looks similar to progress and reject.

@james-criscuolo

Copy link
Copy Markdown
Collaborator

This looks good, thank you. I spoke to John about this and it looks like it's an inconsistency that we can't explain. We hope to do a pass over the whole library to make sure extraHeaders are consistent, but this is a needed addition for now.

@james-criscuolo
james-criscuolo merged commit 36d92b4 into onsip:master Feb 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants