Repository navigation
fix: skip force-kill logging when no processes remain - #616
Merged
gustavohenke merged 1 commit intoSep 4, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Problem
When
killTimeoutis enabled, a process may exit normally after receiving the initial termination signal. The timeout callback currently treats the resulting empty command array as truthy and logsSending SIGKILL to 0 processes.., even though no force kill occurs.Fix
Only log and send
SIGKILLwhen the timeout callback finds at least one process that is still killable.Testing
pnpm vitest run --project unit lib/flow-control/kill-others.spec.tsCI=1 pnpm testpnpm exec vitest --coveragepnpm typecheckpnpm lintpnpm formatpnpm buildpnpm test:smoke