add stdout memory mode - #6774
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6774 +/- ##
============================================
+ Coverage 90.10% 90.58% +0.48%
- Complexity 6541 6582 +41
============================================
Files 728 731 +3
Lines 19695 19714 +19
Branches 1935 1926 -9
============================================
+ Hits 17746 17858 +112
+ Misses 1349 1259 -90
+ Partials 600 597 -3 ☔ View full report in Codecov by Sentry. |
|
@jack-berg this is the final PR for stdout - adding the memory mode feature |
|
|
||
| import io.opentelemetry.sdk.common.export.MemoryMode; | ||
|
|
||
| public class OtlpStdoutExporterBuilderUtil { |
There was a problem hiding this comment.
Missing internal boilerplate javadoc.
There was a problem hiding this comment.
why did the build not fail?
There was a problem hiding this comment.
There's not a build check for it right now. Do you know if opentelemetry-java-instrumentation managed to add this automation yet?
There was a problem hiding this comment.
| } | ||
| }.export(logs); | ||
| } else { | ||
| for (ResourceLogsMarshaler resourceLogs : ResourceLogsMarshaler.create(logs)) { |
There was a problem hiding this comment.
It doesn't seem to be the case that if wrapperJsonObject = false, we can't take advantage of reuseable memory mode. Can we include wrapperJsonObject as an argument to LogReuseableDataMarshaler and adjust the logic accordingly?
There was a problem hiding this comment.
that's not so easy, because
takes a list and I didn't follow what has to be modified in there
d5021a9 to
cfabe23
Compare
|
@jack-berg can you trigger the failed link check? otherwise, everything should be fine |
jack-berg
left a comment
jack-berg
left a comment
There was a problem hiding this comment.
Looks good besides the missing internal boilerplate javadoc. Thanks!
3 participants
No description provided.