Skip to content

gNMI-1.21: Missing integrated-circuit utilization telemetry state paths in README.md #5791

Open

Description

@devansh-lodha

Describe the bug
The test specification in feature/platform/integrated_circuit/otg_tests/utilization_test/README.md omits four integrated-circuit utilization telemetry state paths that are explicitly queried and asserted in utilization_test.go:

  1. /components/component/integrated-circuit/utilization/resources/resource/state/max-limit
  2. /components/component/integrated-circuit/utilization/resources/resource/state/used-threshold-upper
  3. /components/component/integrated-circuit/utilization/resources/resource/state/used-threshold-upper-clear
  4. /components/component/integrated-circuit/utilization/resources/resource/state/used-threshold-upper-exceeded

Additionally, README.md was missing a valid non-empty Canonical OC JSON block representing the test configuration.

To Reproduce
Steps to reproduce the behavior:

  1. Inspect feature/platform/integrated_circuit/otg_tests/utilization_test/utilization_test.go:
    • Line 163: Discovers components via components.FindActiveComponentsByType(t, dut, oc.PlatformTypes_OPENCONFIG_HARDWARE_COMPONENT_INTEGRATED_CIRCUIT).
    • Lines 182 & 211: Iterates over each discovered INTEGRATED_CIRCUIT component (for _, c := range comps).
    • Lines 255-270 (awaitUtilization) & Lines 353-368 (componentUtilizations): Queries max-limit, used-threshold-upper, used-threshold-upper-clear, and used-threshold-upper-exceeded.
    • Lines 130-139 (validateUtilizationExceeded) & Line 199: Asserts threshold crossings and max-limit (if u.used+u.free > u.maxLimit).
  2. Inspect feature/platform/integrated_circuit/otg_tests/utilization_test/README.md and observe missing telemetry state paths under paths: and missing Canonical OC block.

Expected behavior
README.md should register the four verified INTEGRATED_CIRCUIT utilization telemetry state paths with platform_type: ["INTEGRATED_CIRCUIT"], include a valid non-empty Canonical OC JSON block, and pass validate_readme_ocpaths and validate_readme_canonicalocspec.

Logs
N/A (Specification gap & validator audit)

Network device platform:

  • Device: Universal / OTG Testbed
  • OS: OpenConfig / Ondatra
  • Version of the test: main branch (utilization_test)

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

bugSomething isn't working

Type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions