Repository navigation
feat(oauth): add --oauth-allow-issuer-mismatch - #8
Merged
Merged
Conversation
Accept HTTPS issuer aliases within the same PSL registrable domain and effective port, with an explicit cross-domain override. Pin the metadata issuer for exact callback validation. Support dynamic client registration with none, Basic, and Post authentication, preserving the returned method and required secret in vault refresh settings. Cover discovery, callback binding, and the CLI-to-vault flow with regression tests. Assisted-by: pi
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
jiangpengcheng
approved these changes
Sep 30, 2026
This was referenced Sep 30, 2026
Merged
Merged
Merged
Merged
Merged
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes and why
Introduce
--oauth-allow-issuer-mismatchfor MCP OAuth integrations whose authorization-server discovery identifiers differ. This explicit option is intended for trusted providers and prints a warning to stderr without affecting JSON stdout.none,client_secret_basic, orclient_secret_post. Honor the registration response when exchanging codes and storing Vault refresh settings; never print or persist OAuth secrets locally.Pre-registered
--oauth-client-idremains public-client-only. No client-secret command-line argument is introduced.Compatibility
--oauth-allow-issuer-mismatchandmcpoauth.Options.AllowIssuerMismatch, and extends dynamic client authentication support as described above. Existing leaf commands and credential-result output formats are unchanged.How I tested it
Passed locally:
The command E2E fixtures exercise discovery, registration, PKCE callbacks, token exchange, Vault refresh configuration, and output redaction without a real login or external credential writes.
The broader workspace race check exposes existing global-state races in parallel help tests. These were reproduced on the unmodified base commit; the OAuth-focused race checks above pass.
AI assistance
Checklist
Assisted-by:trailer.