Repository navigation
[stable9.1] getJailedPath expects $path to have a trailing / (#25703) - #25737
Merged
PVince81 merged 1 commit intoAug 11, 2016
Merged
Conversation
DeepDiver1975
commented
Aug 9, 2016
DeepDiver1975
commented
Contributor
- getJailedPath expects $path to have a trailing / - fixes Error sharing a Shared Folder #25464
- Adding test case for getPathById including a jailed cache where root is just empty
* getJailedPath expects $path to have a trailing / - fixes #25464 * Adding test case for getPathById including a jailed cache where root is just empty
|
@DeepDiver1975, thanks for your PR! By analyzing the annotation information on this pull request, we identified @icewind1991, @rullzer and @PVince81 to be potential reviewers |
Contributor
|
Code looks good 👍 |
Contributor
|
👍 |
|
I just applied the DIFF into my 9.1 instance and the shared link creation on a shared (external storage) folder works. thanks |
PVince81
deleted the
stable9.1-99611d277521b84a943f68d48fe05f290127db7e
branch
August 11, 2016 19:28
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.