You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
No successful run was found on main (654bb80) during the generation of this report, so 27ee297 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩
Wow @Tpt this looks amazing. This looks like it was an enormous amount of work.
Do you think this will (eventually) become the default query evaluator?
Are there any downsides, eg, particularly with regard to DataFusion using Apache Arrow in-memory structures, and the whole Oxigraph->Arrow conversion overhead?
@ashleysommer Thank you! Was much easier than the JSON-LD streaming parser (I have not finished it...). It currently has a few downsides:
much larger dependency footprint
currently much slower on "BSBM explore 5000 query in memory" it takes 150s vs <1s. My guess is that having better join reordering and use for loop joins where it makes sense might help a lot
the conversion to Arrow is indeed very costly. I am considering writing a new storage backend on top of Parquet, likely for read-only workloads first
EXISTS support is currently very spotty and it will require significant work to get it done properly
RocksDB iter is quite slow, making large reads not very good. Tweaking RocksDB evaluation to do less hash/merge joins and more "for loop" joins is needed to keep the same performances on top of RocksDB (and nudges more toward rewriting the storage to be more read-friendly at the cost of maybe being less write-friendly)
EXISTS and LATERAL are written as correlated queries. Sadly DataFusion does not know how to evaluate them without decorating the queries first. We should either change the emitted logical plan in something DataFusion is able to decorellate, write a better decorrelation algorithm or add correlated evaluation to DataFusion (this is sorted by personal order of preference).
This branch has not been deployed
No deployments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Very WIP, will stay a draft for a long time