Repository navigation
Switch components - #181
Conversation
…itor.. next time will less commits.
|
I don't understand this alphabetical sorting.. Why good/better? |
|
You're right, especially when I see this: bottom: 0;
cursor: pointer;
left: 0;
position: absolute;
right: 0;
top: 0;and instead as humans we expect to see position: absolute;
bottom: 0;
left: 0;
right: 0;
top: 0;
cursor: pointer;We will take into consideration proper lint rules when working for the v2 of PaperCSS. |
rhyneav
left a comment
rhyneav
left a comment
There was a problem hiding this comment.
100% agree about the lint rules with you guys. The rationale behind doing it alphabetically is to avoid bike-shedding by not having to think about where to put position vs color vs shadow properties; it’s all in the same order every time. That said, maybe there’s a happy medium where these position elements can be put together...
Anyways, these switches look amazing! Really well done! The initial comments I have are to make sure you are using the colors given in the config file rather than hardcoding them with the switches. Same with the shadows. But these are really cool, excited to have these in PaperCSS. Thank you for your contribution!
|
Hi @rhyneav ! I want a bit different for better visibility :( , but I changed to variable colors. |
|
I totally understand, it just makes the framework easier to customize when all of the colors use the variables. But these look great! I really like the animations on all of them. Thank you for your contribution! |
3 participants
Brief description
Switch components.
Issue: Switch component #121
Sample pictures
Further details
2x2+1 variable styled switches.