Repository navigation
Feature: Paper style for range sliders - #213
Merged
Merged
Conversation
(cherry picked from commit 28d49a3)
1 task done
Member
|
Thank you for the PR! I think this is really close to being perfect. The only thing I would recommend changing is removing the default input box so that the range pickers look slightly more native, like this:
Other than that, these look really nice! I love the imperfect slider button you've made! |
Contributor
Author
|
@rhyneav I've pushed changes to remove the default border. Indeed, it looks more native but I kind of liked the way that the border changed color when focused. But that's not really important 😅 Thanks ! I reused the same technique as for the other switches. |
Member
|
Thank you! I'll merge this in and get it ready for the next release! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brief description
Add style for the range sliders, overriding the track and the thumb in order to look the same on most of browsers (tested on Chrome, Firefox and IE).
Developer Certificate of Origin
Sample pictures
Further details
See Issue #210
Ressources :