Skip to content

feat: make doc links dynamic - #933

Merged
mtrezza merged 6 commits into
parse-community:gh-pagesfrom
dblythy:dynamic-docs
Jun 13, 2023
Merged

mtrezza merged 6 commits into
parse-community:gh-pagesfrom
dblythy:dynamic-docs

Conversation

@dblythy

@dblythy dblythy commented Jun 12, 2023 •

Copy link
Copy Markdown
Member

Currently, the doc links are fixed. This can be changed by building them dynamically.

The file js/links could be served either here or on parseplatform.org.

Related: parse-community/parse-community.github.io#49

Closes #932

@dblythy

dblythy commented Jun 12, 2023

Copy link
Copy Markdown
Member Author

The one file used by both sites will create a more consistent docs link experience.

Screenshot 2023-06-12 at 7 01 30 pm

Screenshot 2023-06-12 at 7 02 50 pm

@mtrezza mtrezza left a comment •

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, can this be merged? Or should we wait for parse-community/parse-community.github.io#49 to be ready, just in case?

@dblythy

dblythy commented Jun 12, 2023 •

Copy link
Copy Markdown
Member Author

We do #49 first, and then add a script tag pointing to the links file at parseplatform.org

@mtrezza

mtrezza commented Jun 12, 2023

Copy link
Copy Markdown
Member

@dblythy

dblythy commented Jun 13, 2023

Copy link
Copy Markdown
Member Author

Cool, this is good to merge

@mtrezza
mtrezza merged commit 2733430 into parse-community:gh-pages Jun 13, 2023
@dblythy
dblythy deleted the dynamic-docs branch June 13, 2023 08:05
@dblythy dblythy mentioned this pull request Jun 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix docs page

2 participants