fix: Custom auth adapters that extend the AuthAdapter class accept any authData (GHSA-rq3w-5c6f-p7wr) by mtrezza · Pull Request #10774 · parse-community/parse-server

mtrezza · 2026-10-09T21:05:49Z

Issue

Custom auth adapters that extend the AuthAdapter class accept any authData (GHSA-rq3w-5c6f-p7wr)

Tasks

Add tests
Add changes to documentation (guides, repository pages, code comments)
Add security check
Add new Parse Error codes to Parse JS SDK

parse-github-assistant · 2026-10-09T21:05:53Z

🚀 Thanks for opening this pull request! We appreciate your effort in improving the project. Please let us know once your pull request is ready for review.

Tip

Keep pull requests small. Large PRs will be rejected. Break complex features into smaller, incremental PRs.
Use Test Driven Development. Write failing tests before implementing functionality. Ensure tests pass.
Group code into logical blocks. Add a short comment before each block to explain its purpose.
We offer conceptual guidance. Coding is up to you. PRs must be merge-ready for human review.
Our review focuses on concept, not quality. PRs with code issues will be rejected. Use an AI agent.
Human review time is precious. Avoid review ping-pong. Inspect and test your AI-generated code.

Note

Please respond to review comments from AI agents just like you would to comments from a human reviewer. Let the reviewer resolve their own comments, unless they have reviewed and accepted your commit, or agreed with your explanation for why the feedback was incorrect.

Caution

Pull requests must be written using an AI agent with human supervision. Pull requests written entirely by a human will likely be rejected, because of lower code quality, higher review effort and the higher risk of introducing bugs. Please note that AI review comments on this pull request alone do not satisfy this requirement. Our CI and AI review are safeguards, not development tools. If many issues are flagged, rethink your development approach. Invest more effort in planning and design rather than using review cycles to fix low-quality code.

coderabbitai · 2026-10-09T21:05:59Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI
Review profile: CHILL
Plan: Essentials
Run ID: d2fb60a1-cb05-4476-9403-d950d4b7ef5f

📥 Commits

Reviewing files that changed from the base of the PR and between ff10828 and 3cfd87d.

📒 Files selected for processing (3)

spec/vulnerabilities.spec.js
src/Adapters/Auth/index.js
src/Auth.js

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review.

📝 Walkthrough

Walkthrough

Custom authentication adapter loading now handles class instances separately from plain-object adapters. New specifications cover adapter validation and behavior across authentication operations. Auth-data lookup skips providers whose submitted data is exactly null.

Changes

Authentication adapter handling

Layer / File(s)	Summary
Custom adapter loading and configuration `src/Adapters/Auth/index.js`, `spec/vulnerabilities.spec.js`	Adapter loading now distinguishes built-in providers, custom class instances, and other adapters. Specifications cover adapter forms, provider hooks, and preservation of the configured instance during validation.
Adapter validation and auth-data processing `spec/vulnerabilities.spec.js`, `src/Auth.js`	Specifications cover token validation across authentication operations, instance-specific behavior, returned auth data, and provider unlinking. Auth-data lookup skips providers whose submitted data is exactly `null`.

Priority: ➖ Normal

Estimated code review effort: 3 (Moderate) | ~25 minutes

Merge Risk: ⚪ Minimal · up to 3cfd8

No actionable issue remains from the reviewed changes; the PR is mergeable after normal checks.

Caution

Pre-merge checks failed

Please resolve all errors before merging. Addressing warnings is optional.

Ignore

❌ Failed checks (1 error, 1 warning)

Check name	Status	Explanation	Resolution
Description check		No pull request description was provided. The required Issue, Approach, and Tasks sections are missing, along with the change summary and task status.	Add a pull request description that follows the repository template. Describe the issue, summarize the implementation approach, and mark the applicable Tasks as completed or remove tasks that do not apply.
Docstring Coverage		Docstring coverage is 60.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 5 functions across 3 files.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check		The title uses the required `fix:` prefix and identifies the security advisory being addressed. The first letter after the prefix is capitalized.
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.
Security Check		The change addresses GHSA-rq3w-5c6f-p7wr without introducing an evident security weakness. `loadAuthAdapter` now uses own-property lookup for built-in providers, removes inherited default `AuthAdapter…
Engage In Review Feedback		The current review produced zero actionable findings. No review feedback required engagement, implementation, or reviewer agreement.

Fix all pre-merge checks with AI

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create a new PR

Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

_{Comment @coderabbitai help to get the list of available commands.}

mtrezza · 2026-10-09T21:06:21Z

@coderabbitai review

coderabbitai · 2026-10-09T21:06:29Z

✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

coderabbitai

Pre-merge checks failed. Please resolve the failing checks before merging.

## [8.6.102](8.6.101...8.6.102) (2026-10-10) ### Bug Fixes * Custom auth adapters that extend the AuthAdapter class accept any authData ([GHSA-rq3w-5c6f-p7wr](https://github.com/parse-community/parse-server/security/advisories/GHSA-rq3w-5c6f-p7wr)) ([#10774](#10774)) ([c000850](c000850))

parseplatformorg · 2026-10-10T01:57:05Z

🎉 This change has been released in version 8.6.102

fix: GHSA-rq3w-5c6f-p7wr

3cfd87d

coderabbitai Bot requested changes Oct 9, 2026

View reviewed changes

coderabbitai Bot approved these changes Oct 9, 2026

View reviewed changes

mtrezza changed the title ~~fix: GHSA-rq3w-5c6f-p7wr~~ fix: Custom auth adapters that extend the AuthAdapter class accept any authData (GHSA-rq3w-5c6f-p7wr) Oct 10, 2026

mtrezza merged commit c000850 into parse-community:release-8.x.x Oct 10, 2026
11 of 26 checks passed

mtrezza deleted the fix/GHSA-rq3w-5c6f-p7wr-v8 branch October 10, 2026 01:55

parseplatformorg added the state:released-8.x.x Released as LTS version label Oct 10, 2026

Navigation Menu

Repository navigation

fix: Custom auth adapters that extend the AuthAdapter class accept any authData (GHSA-rq3w-5c6f-p7wr) - #10774

fix: Custom auth adapters that extend the AuthAdapter class accept any authData (GHSA-rq3w-5c6f-p7wr)#10774
mtrezza merged 1 commit into
parse-community:release-8.x.xfrom
mtrezza:fix/GHSA-rq3w-5c6f-p7wr-v8

mtrezza commented Oct 9, 2026 •

edited

Loading

Uh oh!

parse-github-assistant Bot commented Oct 9, 2026

Uh oh!

coderabbitai Bot commented Oct 9, 2026 •

edited

Loading

Walkthrough

Changes

Pre-merge checks failed

Uh oh!

mtrezza commented Oct 9, 2026

Uh oh!

coderabbitai Bot commented Oct 9, 2026 •

edited

Loading

Uh oh!

coderabbitai Bot left a comment

Uh oh!

Uh oh!

parseplatformorg commented Oct 10, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

mtrezza commented Oct 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Issue

Tasks

Uh oh!

parse-github-assistant Bot commented Oct 9, 2026

Uh oh!

coderabbitai Bot commented Oct 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Pre-merge checks failed

❌ Failed checks (1 error, 1 warning)

Uh oh!

mtrezza commented Oct 9, 2026

Uh oh!

coderabbitai Bot commented Oct 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

parseplatformorg commented Oct 10, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

mtrezza commented Oct 9, 2026 •

edited

Loading

coderabbitai Bot commented Oct 9, 2026 •

edited

Loading

coderabbitai Bot commented Oct 9, 2026 •

edited

Loading