Skip to content

External File Adapter Dependencies #1434

Closed

Description

@mamaso

Hey, noticed that the GCS file adapter was moved to devDependencies in this commit 1eb2a87

I like the opt-in approach to these dependencies for production parse servers, any similar plans for S3 / ParseFS adapters?

Activity

  1. drew-gross commented on Apr 8, 2016

    @drew-gross
    Contributor

    The reason for that one is because the one of the transitive dependencies needed to compile native code and required more than 1GB of RAM to do so, causing install failures on AWS micro instances. I agree that it's a better model to have the dependencies be opt-in, but thats also a breaking change and I'm not sure if the benefit of the breaking change justifies the cost to everyone else, like it did with the GCS adapter.

  2. mamaso commented on Apr 11, 2016

    @mamaso
    Author

    Makes sense, not worth the pain of the breaking change unless if there are extenuating circumstances like native module failures. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions