Does this support the textScore from MongoDB? I don't see a test for it or any of the code, though everything else is pretty similar to my PR

Working on a test case now. Unless you want to do it.

Yeah try to coordinate into a single PR if possible @dplewis, you seem well versed into Postgres, why don't you add support to it on @seriph's PR?

Codecov Report

Merging #3904 into master will increase coverage by 0.02%.
The diff coverage is 96.29%.

@@            Coverage Diff             @@
##           master    #3904      +/-   ##
==========================================
+ Coverage   90.26%   90.28%   +0.02%     
==========================================
  Files         114      114              
  Lines        7588     7641      +53     
==========================================
+ Hits         6849     6899      +50     
- Misses        739      742       +3

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5f991e9...c54865f. Read the comment docs.

@flovilmart I would do that but I don't like how @seriph copy and pasted my PR an hour after I posted it.

He had over a month to do a PR.

Also I announced that I was going to do a PR so something like this wouldn't happen.

@seriph's code is way old, and that's open source, let's work together to be more efficient, it's not a time for disputes guys.

You gotta treat people with respect man, the way you're acting and telling @seriph down is not acceptable, not matter how many commits you have in the project. @seriph had a fork with the feature in months ago, and I expect he's now pissed and not likely to contribute to the project again. Read our CODE_OF_CONDUCT. I can not tolerate your behaviour with other contributors.

@flovilmart I understand it won't happen again. @seriph I'll help you get this PR in

Also, on the code side, $text should not be a special key, but the REST format should be:

{
  "myKey": {
     "$text": {
        "$search": ...
      }
  }
}

Haha, to tell you the truth @dplewis I suspected you did the same when I saw you'd posted in the thread where someone had asked me about my fork, then your PR shows up with almost identical code. The textScore code has been live in production on an ecommerce site for months, so surprised you're not thinking it works. Thanks for the professionalism @flovilmart, happy to contribute in the future. I have matching code for the JS API if it helps.

So we're all good then, if you guys can coordinate, and work together to get the best of that PR, I'll happily create a new full-text-search branch, where you can both merge your PR's before we merge the full-text-search in master. What do you think?

@flovilmart since you can only have 1 Text Index "myKey" doesn't matter.

@seriph I just added a commit for textScore and a test for it. Look at it and you'll see why I thought your textScore didn't work. I didn't see a keyword 'textScore' in any of the docs.

@flovilmart thanks for creating that branch.

@flovilmart do we commit to that branch and move the conversation over to @seriph PR.

Is that true as well for Postgres? (The single index?)

Postgres doesn't need an index but can only have 1 index

Mongo throws an error if index doesn't exist. I'm writing a test case for it now.

And on Postgres, there's no need either to specify which key of the table will be looked up for search?

I'm still doing research on it. But we'll know soon enough.

From the looks of it were going to use SELECT [mykey] FROM [className] or SELECT to_tsvector()

I still have 4 test cases to write then we can merge.

Index Exists
Multiple Index Error
Space Delimiter
Phrases

@dplewis are you sure you need to to change the find function of the mongoStorageAdapter? @seriph's version with an update of mongoCollection seems simpler, but I'm not good enough in JS to judge :)
I just feel adding those 16 lines in mongoStorageAdapter is less clean than the rest of the code :)
My 2 cents

@SebC99 For some reason I couldn't get Mongocollection.find(query...) to handle 2 projections mongoWhere, {{score...}} Which I found to be neccessary after research.

@seriph can you run the test cases against your code? You may have to change the REST format.

@flovilmart I've added support for Postgres. Users have to keep in mind that this will have unexpected consequences if their indexes aren't set up properly

Also is travis not running because of the parse-community:full-text-search branch?

closing to force travis to pick up the build

It's looking super great IMHO, @seriph what do you think?

I separated the tests and added the error messages

Sorry to ask for something more, could we put all the tests in a new file? The ParseQuery.spec.js is already huge :) perhaps ParseQuery.FullTextSearch.spec.js?

@flovilmart Sure no problem. Glad I could help. How should we format this?
query.fullTextSearch(key, options)?

@seriph can you work on updating the javascript sdk?

For now let's start with the REST docs, we'll see the SDK's after right?

Right

Any chance that an API for this will come into the JS SDK?

https://docs.parseplatform.org/js/guide/#full-text-search

It seems there is a query.fullText()

but returns empty array

@flovilmart