Skip to content

volatileClasses are masterKey only - #3916

Merged
flovilmart merged 3 commits into
parse-community:masterfrom
pungme:pung-volatileClassesShouldRespectSchema
Jun 13, 2017
Merged

volatileClasses are masterKey only #3916
flovilmart merged 3 commits into
parse-community:masterfrom
pungme:pung-volatileClassesShouldRespectSchema

Conversation

@pungme

@pungme pungme commented Jun 8, 2017 •
edited
Loading

Copy link
Copy Markdown
Contributor
  • Hey! this is my first PR ever, feel free to suggest anything. I'm still learning the best practice!
  • basically, all the volatileClasses are masterKey only
  • potentially fix VolatileClass ignores the CLP #3915

@pungme

pungme commented Jun 8, 2017

Copy link
Copy Markdown
Contributor Author

I think I should add some test about this case also ...

@codecov

codecov Bot commented Jun 8, 2017 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #3916 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3916      +/-   ##
==========================================
+ Coverage   90.24%   90.24%   +<.01%     
==========================================
  Files         114      114              
  Lines        7584     7588       +4     
==========================================
+ Hits         6844     6848       +4     
  Misses        740      740
Impacted Files Coverage Δ
src/Controllers/SchemaController.js 97.04% <ø> (ø) ⬆️
src/rest.js 97.18% <100%> (+0.16%) ⬆️
src/RestWrite.js 93.12% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c4fbc1f...c81e6e7. Read the comment docs.

@pungme pungme changed the title volatileClass should respect the schema if defined volatileClass is masterKey only Jun 8, 2017
@natanrolnik

natanrolnik commented Jun 8, 2017

Copy link
Copy Markdown
Contributor

@pungme Would you mind adding a few tests to check this behavior?

@pungme

pungme commented Jun 8, 2017 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

@natanrolnik sure! I'll add some test

@pungme pungme changed the title volatileClass is masterKey only volatileClasses is masterKey only Jun 8, 2017
@pungme pungme changed the title volatileClasses is masterKey only volatileClasses are masterKey only Jun 8, 2017
@pungme

pungme commented Jun 12, 2017

Copy link
Copy Markdown
Contributor Author

Hey, Is it ok like this? Or should I add more test to it?

@flovilmart

flovilmart commented Jun 12, 2017

Copy link
Copy Markdown
Contributor

I'll have a look later today! Thanks

@flovilmart

flovilmart commented Jun 13, 2017

Copy link
Copy Markdown
Contributor

Alright this is looking great and I was about to need it for something else!

@flovilmart
flovilmart merged commit 7d70af6 into parse-community:master Jun 13, 2017
@pungme

pungme commented Jun 13, 2017

Copy link
Copy Markdown
Contributor Author

awesome, cheers!

@montymxb montymxb mentioned this pull request Jun 21, 2017
Closed
@flovilmart flovilmart modified the milestone: 2.5.0 Jun 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@natanrolnik natanrolnik natanrolnik approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

2.5.0

Development

Successfully merging this pull request may close these issues.

VolatileClass ignores the CLP

3 participants

@pungme @natanrolnik @flovilmart