Repository navigation
fix(#3898): session token deletion - #3937
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3937 +/- ##
==========================================
+ Coverage 90.43% 90.48% +0.05%
==========================================
Files 114 114
Lines 7682 7686 +4
==========================================
+ Hits 6947 6955 +8
+ Misses 735 731 -4
Continue to review full report at Codecov.
|
acinader
previously approved these changes
Jun 16, 2017
| }); | ||
|
|
||
| it('cannot update session if invalid or no session token', (done) => { | ||
| Parse.Promise.as().then(() => { |
Contributor
There was a problem hiding this comment.
hm. just out of curiosity, why do you need this noop promise?
Contributor
Author
There was a problem hiding this comment.
not needed per se, but that's how the test was originally written.
|
|
||
| const firstResult = response.results[0]; | ||
| firstResult.className = className; | ||
| if (className == '_Session' && !auth.isMaster) { |
Contributor
There was a problem hiding this comment.
prefer === i should prolly get that in lint....surprised it isn't already there.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes sure the user trying to make the delete call on _Session is the one owning it. Props to @pungme for writing the test and getting it started!