Repository navigation
Use LRU cache as default mechanism for caching in memory - #3979
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3979 +/- ##
==========================================
- Coverage 90.58% 90.57% -0.02%
==========================================
Files 115 116 +1
Lines 7788 7797 +9
==========================================
+ Hits 7055 7062 +7
- Misses 733 735 +2
Continue to review full report at Codecov.
|
benishak
approved these changes
Jun 30, 2017
benishak
left a comment
benishak
left a comment
Contributor
There was a problem hiding this comment.
LRUCache is definitely a good choice!
acinader
previously approved these changes
Jun 30, 2017
Contributor
Author
|
@acinader It's deployed in production now, I'll keep monitoring to check if this will be fine over time |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.