Skip to content

Add QA Tools / Linters #67

Open
Open

Description

@Potherca

We want to add CI/CD tools to all PDS Interop PHP repositories that are dependencies for this repository.

This ticket serves as full list of all the steps that need to be taken.
For all repositories the steps are more or less the same:

  • Create a .github/workflows directory
  • Create a YAML workflow file to lint for PHP syntax errors
  • Create a YAML workflow file to check for PHP version compatibility (PHP Compat)
  • Create a YAML workflow file to check for style violations (PHP CodeSniffer)
  • Create a YAML workflow file to do security checks
  • Create a YAML workflow file to run PHPUnit tests (similar to tests.yml)

This means our worklist is:

  • solid-nextcloud

    • Workflow to lint for PHP syntax errors
    • Workflow to check for PHP version compatibility
    • Workflow to check for style violations
    • Workflow to do security checks
    • Workflow to run PHPUnit tests see Workflow to run PHPUnit tests #81
  • php-solid-auth

    • Workflow to lint for PHP syntax errors
    • Workflow to check for PHP version compatibility
    • Workflow to check for style violations
    • Workflow to do security checks
    • Workflow to run PHPUnit tests
  • php-solid-crud

    • Workflow to lint for PHP syntax errors
    • Workflow to check for PHP version compatibility
    • Workflow to check for style violations
    • Workflow to do security checks
    • Workflow to run PHPUnit tests
  • flysystem-nextcloud

    • Workflow to lint for PHP syntax errors
    • Workflow to check for PHP version compatibility
    • Workflow to check for style violations
    • Workflow to do security checks
    • Workflow to run PHPUnit tests
  • flysystem-rdf

    • Workflow to lint for PHP syntax errors
    • Workflow to check for PHP version compatibility
    • Workflow to check for style violations
    • Workflow to do security checks
    • Workflow to run PHPUnit tests

If so desired, this list can be broken out into separate tickets in each repo.

Activity

  1. ylebre commented on Aug 26, 2022

    @ylebre
    Member
  2. ylebre commented on Aug 26, 2022

    @ylebre
    Member

    Since the security check only validates dependancies, we are only adding it to the solid-nextcloud repo:

    #79

  3. ylebre commented on Aug 26, 2022

    @ylebre
    Member

    Above PRs are merged.

  4. ylebre commented on Aug 26, 2022

    @ylebre
    Member

    Adding PHP version sniff for solid-nextcloud:
    #80

  5. ylebre commented on Aug 26, 2022

    @ylebre
    Member

    Above PR is merged.

  6. ylebre commented on Aug 26, 2022

    @ylebre
    Member

    PHPunit for flysystem/nextcloud: pdsinterop/flysystem-nextcloud#9

  7. ylebre commented on Aug 26, 2022

    @ylebre
    Member

    PHPUnit for php-solid-crud: pdsinterop/php-solid-crud#20

  8. ylebre commented on Aug 26, 2022

    @ylebre
    Member

    PHPunit for php-solid-auth: pdsinterop/php-solid-auth#24

  9. added this to the v0.6.0 milestone on Sep 24, 2022
  10. modified the milestones: v0.6.0, v0.7.2 on Oct 19, 2022
  11. modified the milestones: v0.7.2, v0.7.3 on Jan 23, 2023
  12. Potherca commented on Jan 20, 2024

    @Potherca
    MemberAuthor

    PHP Code standard added in 3aa3097 and b801021

  13. removed this from the v0.7.3 milestone on Jan 20, 2024
  14. added
    Type: QAIssues regarding the quality of the code and application
    on Jan 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Type: QAIssues regarding the quality of the code and application

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions