Skip to content

Implement 'remove bucket' feature - #310

Merged
igungor merged 7 commits into
peak:masterfrom
ocakhasan:remove
Jul 5, 2021
Merged

igungor merged 7 commits into
peak:masterfrom
ocakhasan:remove

Conversation

@ocakhasan

@ocakhasan ocakhasan commented Jul 2, 2021

Copy link
Copy Markdown
Contributor

Resolves #303

@ocakhasan
ocakhasan marked this pull request as ready for review July 2, 2021 13:57
@ocakhasan
ocakhasan requested review from a team, igungor and ilkinulas and removed request for a team July 2, 2021 13:57
Comment thread e2e/rb_test.go Outdated
Co-authored-by: İlkin Balkanay <[email protected]>
Comment thread command/rb.go
Comment thread command/rb.go Outdated
Comment thread command/rb.go Outdated
Comment thread command/rb.go Outdated
Comment thread command/rb.go Outdated
Comment thread e2e/rb_test.go Outdated
Comment thread e2e/rb_test.go Outdated
Comment thread e2e/rb_test.go Outdated
Comment thread e2e/rb_test.go Outdated
@igungor igungor changed the title remove bucket feature. Implement 'remove bucket' feature Jul 5, 2021
@igungor

igungor commented Jul 5, 2021

Copy link
Copy Markdown
Member

solves issue #303

We mostly use Resolves #NUMBER or Fixes #NUMBER.

https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue

Comment thread e2e/rb_test.go
Comment thread e2e/rb_test.go Outdated
Comment thread e2e/rb_test.go
@igungor
igungor merged commit 5495dd4 into peak:master Jul 5, 2021
@igungor

igungor commented Jul 5, 2021

Copy link
Copy Markdown
Member

Congrats on your first commit 🎉

@ocakhasan
ocakhasan deleted the remove branch August 2, 2021 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feature: add remove bucket command

3 participants