Skip to content

Support Environment S3_ENDPOINT_URL - #343

Merged
ilkinulas merged 3 commits into
peak:masterfrom
Dexus-Forks:patch-1
Aug 18, 2021
Merged

ilkinulas merged 3 commits into
peak:masterfrom
Dexus-Forks:patch-1

Conversation

@Dexus

@Dexus Dexus commented Aug 17, 2021

Copy link
Copy Markdown
Contributor

Make the S3_ENDPOINT_URL environment variable usable to omit the --endpoint-url flag.

Closes #326

@Dexus
Dexus requested review from a team, ilkinulas and seruman and removed request for a team August 17, 2021 18:01
@ilkinulas

Copy link
Copy Markdown
Member

Thank you for your contribution.
Could you please update README? There is a section where --endpoint-url is documented. You can add a sample usage there.

@Dexus

Dexus commented Aug 18, 2021

Copy link
Copy Markdown
Contributor Author

@ilkinulas
I add the example in the README.

@Dexus

Dexus commented Aug 18, 2021

Copy link
Copy Markdown
Contributor Author

fix the "fmt check"

@ilkinulas
ilkinulas merged commit a0791f8 into peak:master Aug 18, 2021
@joshuarobinson

Copy link
Copy Markdown

Great idea! thanks for this change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make --endpoint-url also usable as ENV

4 participants