Skip to content

Add missing sync command flags - #409

Merged
sonmezonur merged 23 commits into
masterfrom
sync_missing_flags
Mar 25, 2022
Merged

sonmezonur merged 23 commits into
masterfrom
sync_missing_flags

Conversation

@sonmezonur

@sonmezonur sonmezonur commented Feb 21, 2022

Copy link
Copy Markdown
Member

Resolves #3, resolves #365, fixes #397, fixes #416

Adding missing flags and following changes:

  • sync command can use same validation methods with cp. Currently, it does not accept single object sync and other validation logic is exactly the same with cp command. I don't see any reason for not supporting this:
sync s3://bucket/source.go .
  • Updated givenCommand() method to add flags to command string.

  • Added e2e tests for --exclude, --raw and --no-follow-symlinks and unit tests for other flags

  • Below flags are not tested:

sse
sse-kms-key-id
acl
cache-control
expires
force-glacier-transfer

@sonmezonur
sonmezonur requested review from a team, aykutfarsak and igungor and removed request for a team February 21, 2022 14:21
Comment thread e2e/sync_test.go Outdated
@sonmezonur

Copy link
Copy Markdown
Member Author

PTAL. All copy flags should work with sync. Added tests

@vijayreddy579

vijayreddy579 commented Mar 16, 2022

Copy link
Copy Markdown

👍
I'm early waiting for this changes to be merged and an official next version release

@sonmezonur
sonmezonur merged commit b43df69 into master Mar 25, 2022
@sonmezonur
sonmezonur deleted the sync_missing_flags branch March 25, 2022 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

4 participants