Skip to content

Change cp error not being descriptive - #463

Merged
sonmezonur merged 6 commits into
peak:masterfrom
boraberke:change-cp-error-not-being-descriptive
Jul 19, 2022
Merged

sonmezonur merged 6 commits into
peak:masterfrom
boraberke:change-cp-error-not-being-descriptive

Conversation

@boraberke

Copy link
Copy Markdown
Contributor

With this fix, when "given object not found" error message will also include absolute path of the file.

Fixes #461

boraberke added 2 commits July 7, 2022 17:13
With this fix, when "given object not found" error message will also include absolute path of the file.

Fixes peak#461
@boraberke
boraberke requested review from a team, igungor and sonmezonur and removed request for a team July 7, 2022 14:33
@sonmezonur

Copy link
Copy Markdown
Member

@boraberke Thanks, LGTM! Could you describe this change in CHANGELOG?

Comment thread storage/storage.go
Comment thread e2e/cp_test.go Outdated
Comment thread command/cp.go Outdated
@sonmezonur
sonmezonur merged commit 6e3fc4f into peak:master Jul 19, 2022
@boraberke
boraberke deleted the change-cp-error-not-being-descriptive branch July 27, 2022 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

error is not descriptive when cp can't find the given object

3 participants