Skip to content

ci: use Go 1.19 for builds, remove 1.16 support - #481

Merged
igungor merged 3 commits into
peak:masterfrom
kucukaslan:go-1.19
Aug 9, 2022
Merged

ci: use Go 1.19 for builds, remove 1.16 support#481
igungor merged 3 commits into
peak:masterfrom
kucukaslan:go-1.19

Conversation

@kucukaslan

@kucukaslan kucukaslan commented Aug 8, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor
  • use io and os packages to replace deprecated ioutil functions
  • update go.mod go requirement to 1.17

@kucukaslan
kucukaslan requested review from a team, igungor and seruman and removed request for a team August 8, 2022 09:19
@kucukaslan

kucukaslan commented Aug 8, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor Author
  1. Should I also change the go.mod file? Yes

    s5cmd/go.mod

    Line 3 in 7c90f8a

    go 1.13

ps. as of 1.17 indirect dependencies are brought to go.mod in the root https://go.dev/doc/modules/gomod-ref#go

  1. ioutil is deprecated should I change them in this PR? Yes

@kucukaslan

kucukaslan commented Aug 8, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

By the way, it seems go fmt is already being checked:

s5cmd/.github/workflows/ci.yml

Line 63 in 7c90f8a

- run: make check-fmt

and

s5cmd/Makefile

Lines 46 to 50 in 7c90f8a

check-fmt:
@if [ $$(go fmt -mod=vendor ./...) ]; then\
echo "Go code is not formatted";\
exit 1;\
fi

@igungor
igungor merged commit 2a6c7cc into peak:master Aug 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@igungor igungor igungor approved these changes
@seruman seruman seruman approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kucukaslan @igungor @seruman