storage/url: add nil check for URL.filterRegex in URL.Match - #511
Merged
Merged
Conversation
kucukaslan
requested review from
a team,
aykutfarsak and
igungor
and removed request for
a team
September 13, 2022 11:43
igungor
approved these changes
Sep 14, 2022
sonmezonur
self-requested a review
September 16, 2022 12:01
sonmezonur
approved these changes
Sep 16, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
URL.Match method assumes that URL.filterRegex is not nil and used it without check. But if the URL was created with
rawoption or was created with type literal then it might be nil. So if Match was called for such URLs then it panics.ps. It occured in an old variants of autocompletion PR. But that part of the code was changed now, so we won't include this change there.