command: skip nonregular files - #618
Merged
Merged
Conversation
seruman
requested changes
Aug 1, 2023
seruman
left a comment
seruman
left a comment
Contributor
There was a problem hiding this comment.
I do not remember if we ever discussed this but what about outputting some warnings to users?
For example; a cp to a single fifo file exits with 0 without any output which kinda indicates like if it would successfully copied;
~/src/github.com/peak/s5cmd fix-special-files*
; file fifoo
fifoo: fifo (named pipe)
~/src/github.com/peak/s5cmd fix-special-files*
; s5cmd cp fifoo s3://some-bucket/selman/test/; echo $?
0
~/src/github.com/peak/s5cmd fix-special-files*
; s5cmd ls 's3://some-bucket/selman/test/*'
ERROR "ls s3://some-bucket/selman/test/*": no object foundWhat do you think @ilkinulas?
Contributor
Author
I added error messages for skipped objects. It can be good to show information messages. I can revert if it is unnecessary. |
seruman
requested changes
Aug 3, 2023
seruman
reviewed
Aug 3, 2023
seruman
approved these changes
Aug 4, 2023
ahmethakanbesel
changed the title
ilkinulas
approved these changes
Aug 4, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #498
Changes are made:
cpcommand checks file mode bits before trying to copy. If the file is a special file,cpdo not copy that file. It neither returns an error nor prints a message. The copy process continues as usual.syncusescpin the background, it behaves likecp, so it does not sync special files.