makefile: correctly inject vcs information into the binary - #650
Merged
Merged
Conversation
`s5cmd version` is reported incorrectly due to the package name change. Before: ```bash $ s5cmd version v0.0.0-dev ``` After: ```bash $ ./s5cmd version v2.2.0-550a8461 ```
igungor
requested review from
a team,
ilkinulas,
seruman and
sonmezonur
and removed request for
a team and
ilkinulas
August 22, 2023 08:31
seruman
approved these changes
Aug 22, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
s5cmd versionreports incorrect info due to the package name change.Before:
After: