feat: added Head command - #730
Merged
Merged
Conversation
4o4x
requested review from
a team,
igungor and
seruman
and removed request for
a team
July 3, 2024 15:18
seruman
requested changes
Jul 4, 2024
seruman
left a comment
seruman
left a comment
Contributor
There was a problem hiding this comment.
besides the review comments, there're left over comments -mostly in tests-, could please take another look at them.
seruman
reviewed
Jul 4, 2024
seruman
reviewed
Jul 8, 2024
seruman
requested changes
Jul 9, 2024
sonmezonur
reviewed
Jul 9, 2024
sonmezonur
reviewed
Jul 9, 2024
igungor
reviewed
Jul 9, 2024
4o4x
commented
Jul 9, 2024
igungor
reviewed
Jul 12, 2024
Enhancements to `head` command and bug fixes - Added `version-id` and `raw` flags to the `head` command - Fixed issue with metadata printing - Added new tests
The code change corrects a typo in the storage class value in the S3 storage module. The variable `storageClassStr` was misspelled as "STANDART" instead of "STANDARD". This commit fixes the typo to ensure the correct storage class value is used. Note: This suggested commit message follows the convention observed in the recent repository commits.
Support for displaying metadata in the command output.
The regex in the expected output of the head_test.go file has been updated to account for different orderings of key-value pairs in the metadata. This change ensures that the test passes regardless of the order in which the key-value pairs are printed.
seruman
previously approved these changes
Jul 17, 2024
Contributor
Author
|
Hello, we have decided with @ilkinulas that all outputs should be in JSON format, so some parts have been changed in this PR. I would really appreciate it if you could review it again. |
The code change removes the unused code that was setting the relative path in the `Run` method of the `Head` struct.
seruman
reviewed
Jul 25, 2024
igungor
reviewed
Jul 25, 2024
ilkinulas
reviewed
Jul 26, 2024
ilkinulas
approved these changes
Jul 26, 2024
igungor
approved these changes
Jul 26, 2024
seruman
approved these changes
Jul 26, 2024
|
very interested in this. when is next release @ilkinulas @igungor @seruman ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds the
headcommand to the program. Closes #682.The
headcommand is designed to check if a file exists without downloading the object or bucket itself. It retrieves metadata from an object without returning the object itself. This operation is useful for users who are only interested in an object's metadata.Usage:
Check if a bucket exists
Check if a file exists and retrieve its metadata