Repository navigation
feat(hotkey): cancel the recording when the hotkey becomes a shortcut - #835
Open
someonewithpc wants to merge 1 commit into
Open
someonewithpc wants to merge 1 commit into
someonewithpc wants to merge 1 commit into
Conversation
With a modifier as the hotkey, e.g. key = "RIGHTCTRL", every Right Ctrl+C or Right Ctrl+Tab also starts a recording. Short ones get discarded, but a long shortcut or a quick sequence of them dictates whatever was said meanwhile, or pastes it into the wrong place. hotkey.cancel_on_other_key cancels the recording when another key goes down while the hotkey is held. Modifiers, model_modifier and the profile_modifiers keys are exempt, since they're meant to be pressed with the hotkey. Off by default.
Author
|
CI runs correctly locally. Can a maintainer approve the CI workflow? Apologies if I misunderstood the workflow |
someonewithpc
marked this pull request as ready for review
October 5, 2026 16:52
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
With a modifier as the hotkey (
key = "RIGHTCTRL"), every Right Ctrl+C or Right Ctrl+Tab also starts a recording. Short ones are discarded, but a quick run of shortcuts, or one held a little long, dictates whatever was said meanwhilehotkey.cancel_on_other_key = truecancels the recording when any other key goes down while the hotkey is held. Modifiers,model_modifierand theprofile_modifierskeys are exempt, since they're meant to be pressed with the hotkey. Off by defaultRelated Issue
#834
Type of Change
Testing
cargo testand all tests passcargo clippy -- -D warningswith no warningscargo fmtDocumentation
Pre-merge checklist
devbranch (notmain)ci-successto pass before marking Ready for Review (draft mode is encouraged while CI is red)Additional Notes
Running an always-on version daily on 1.1.1-rc5. Unit test for which keys count as a shortcut; docs in
docs/CONFIGURATION.mdandconfig/default.tomlIf the language-modifier PR lands too, its keys should be exempt as well. I'll rebase whichever goes second