Skip to content

fromJSONField: Include JSONPath on JSON parse errors - #2

Merged
phadej merged 1 commit into
haskellari:masterfrom
sol:better-json-errors
Nov 28, 2018
Merged

phadej merged 1 commit into
haskellari:masterfrom
sol:better-json-errors

Conversation

@sol

@sol sol commented Nov 23, 2018

Copy link
Copy Markdown
Contributor

No description provided.

@phadej

phadej commented Nov 23, 2018

Copy link
Copy Markdown
Collaborator

this new fromJSON doesn't seem to be used anywhere?

@sol
sol force-pushed the better-json-errors branch from a90b465 to 75760b8 Compare November 23, 2018 15:52
@sol

sol commented Nov 23, 2018 •

Copy link
Copy Markdown
Contributor Author

this new fromJSON doesn't seem to be used anywhere?

My bad, fixed.

@sol

sol commented Nov 23, 2018

Copy link
Copy Markdown
Contributor Author

@phadej aeson's fromJSON does not include the JSONPath to the location where parsing failed in error messages. I addressed this by using ifromJSON.

@sol
sol force-pushed the better-json-errors branch from 240d187 to ca672c0 Compare November 23, 2018 16:03
@sol
sol force-pushed the better-json-errors branch from ca672c0 to 1938872 Compare November 24, 2018 03:18
@sol

sol commented Nov 28, 2018

Copy link
Copy Markdown
Contributor Author

@phadej is there anything that I can do to move this forward?

@phadej

phadej commented Nov 28, 2018

Copy link
Copy Markdown
Collaborator

@sol this looks good.

@phadej
phadej merged commit 466c469 into haskellari:master Nov 28, 2018
@phadej

phadej commented Nov 28, 2018

Copy link
Copy Markdown
Collaborator

Merged, thanks for the ping

@sol
sol deleted the better-json-errors branch November 28, 2018 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants