Fix #36103: ftp ssl connection fails during login - #355
Closed
kaplanlior wants to merge 1 commit into
Closed
kaplanlior wants to merge 1 commit into
kaplanlior wants to merge 1 commit into
Conversation
Contributor
|
Would be nice to have a test for this, is it possible? |
Contributor
Author
|
I'm just trying to integrate a patch by Yoram, not one I've written myself. I would try to provide a test, but as it's the first time I try, it might take some time. Help/guidance much appreciated. |
|
Comment on behalf of krakjoe at php.net: Since this PR has no tests, and is not satisfactory quality, and has merge conflicts, I'm closing this PR. Please take this action as encouragement to open a clean PR, with tests, and ensure those tests pass. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The patch is available at #63767 as requested.