Skip to content

Declare PHP 8.4 compatibility - #634

Merged
stof merged 1 commit into
phpspec:masterfrom
skilld-labs:624-allow-8.4
Nov 19, 2024
Merged

stof merged 1 commit into
phpspec:masterfrom
skilld-labs:624-allow-8.4

Conversation

@andypost

Copy link
Copy Markdown
Contributor

Closes #624

@Jean85 Jean85 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@Jean85

Jean85 commented Nov 7, 2024

Copy link
Copy Markdown
Contributor

I can report that I'm successfully using master with no issues under PHP 8.4: facile-it/paraunit#279

@stof

stof commented Nov 19, 2024

Copy link
Copy Markdown
Member

@andypost please also update the CI config to have a job running on PHP 8.4

@andypost

Copy link
Copy Markdown
Contributor Author

@stof there's already https://github.com/phpspec/prophecy/blob/master/.github/workflows/build.yml#L24-L25

but to move it above phpspec needs new release

@stof
stof merged commit 0c72ccb into phpspec:master Nov 19, 2024
@andypost
andypost deleted the 624-allow-8.4 branch November 19, 2024 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

PHP 8.4 support

4 participants