Repository navigation
chore: Fix pmd test setup - #6728
Merged
Merged
Conversation
UncleOwen
reviewed
May 28, 2026
Member
|
Thanks for catching this. The other changes look fine. |
Contributor
|
No relevant source code has been changed, pmdtester skipped. (comment created at 2026-06-11 08:35:14+00:00 for 8b7c112) |
Also rename suite test class to avoid executing the tests twice.
adangel
force-pushed
the
chore/fix-pmd-test-setup
branch
from
June 5, 2026 09:10
535d503 to
0c30e92
Compare
UncleOwen
approved these changes
Jun 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the PR
It turns out, that JUnit5TestShouldBePackagePrivate didn't trigger after all, although it has been fixed with #6680.
The reason was, that when using
includeTests=false, the wrong classpath was used by m-pmd-p and e.g. JUnit was missing - and the rule didn't detect any test classes.Related issues
Ready?
./mvnw clean verifypasses (checked automatically by github actions)