Just jotting this down as a minor nit to pick.
Here, we declare plots to use Option<Labels> and I think we can do without the option part.
|
pub labels: Option<Labels>, |
The distinction of 'having no labels field' and 'having a labels field that is empty' is meaningless in the rest of the code. Currently we have to guard against None at every corner, which is a bit of a pain.
Just jotting this down as a minor nit to pick.
Here, we declare plots to use
Option<Labels>and I think we can do without the option part.ggsql/src/plot/main.rs
Line 69 in 779f04e
The distinction of 'having no labels field' and 'having a labels field that is empty' is meaningless in the rest of the code. Currently we have to guard against
Noneat every corner, which is a bit of a pain.