Repository navigation
Translate colours to hexadecimal representation - #62
Merged
Merged
Conversation
teunbrand
marked this pull request as ready for review
January 14, 2026 14:14
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aims to fix #26.
We're using the 'csscolorparser' crate to handle the conversion to hexadecimal strings.
Not only does this give us all CSS's named colours ('BurlyWood', 'Plum', etc.), but also parameterised colours like 'rgb(0,255,0)' or 'hsl(22, 75%, 50%)'. The quotes around these parametrisations are needed at this point.
Currently this conversion is only applied when setting colours via
SETTING color => foo, and not in other places, notablyMAPPING foo AS color. Once we implement manual scales, we should apply this conversion on that scale palette too.