Allow to specify "--cc=msc" as command line. - #2003
Merged
Merged
Conversation
Contributor
Author
Was unrelated to my change, random network issue (502 is Bad Gateway) BTW test was reversed to have correct error message, i.e: - test.isequal(responseCode, 418)
+ test.isequal(418, responseCode) |
samsinsane
approved these changes
Apr 15, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Allow to specify "--cc=msc" as command line (in addition to gcc/clang).
How does this PR change Premake's behavior?
Just the command line to specify
ccAnything else we should know?
Tested on https://github.com/Jarod42/premake-sample-projects/tree/windows_ninja
(More specifically that action run).
Did you check all the boxes?
closes #XXXXin comment to auto-close issue when PR is merged)You can now support Premake on our OpenCollective. Your contributions help us spend more time responding to requests like these!