Repository navigation
Respect prettier-ignore comments before formatting ranges - #20194
Open
davidscottpope-gif wants to merge 1 commit into
Open
davidscottpope-gif wants to merge 1 commit into
davidscottpope-gif wants to merge 1 commit into
Conversation
Automation signalsActivity patterns show signs of automation. Evidence
Last 4 PRs: This is an automated analysis by AgentScan |
✅ Deploy Preview for prettier ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #20164.
Range formatting reparses only the selected source text. When a
prettier-ignorecomment is immediately before the selected statement, it was left out of that text and the statement was formatted anyway.Attach comments before selecting the range, keep ignored source elements intact when the selection falls inside them, and include their leading comments in the text being reparsed. Ordinary comments still allow formatting, and nonignored statements within the selected range are still formatted.
Adds snapshots covering line/block ignore comments, nested ignored statements, selections inside ignored functions, surrounding statements, and a range containing both ignored and nonignored statements. Adds cursor-offset and CRLF tests.
Testing on Linux with Node 22.23.3:
The full integration suite, macOS, and production standalone/browser tests were not run to completion.
Checklist
docs/directory).changelog_unreleased/*/XXXX.mdfile followingchangelog_unreleased/TEMPLATE.md.AI assistance was used to investigate the bug, write the patch and tests, and prepare this description. There are no API or CLI changes. The changelog filename and PR-number placeholder will be updated after this PR is opened.